[imagechest] Add new extractor for ImageChest #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamleot
reviewed
May 18, 2020
gallery_dl/extractor/imagechest.py
Outdated
| if "Sorry, but the page you requested could not be found." in page: | ||
| raise exception.NotFoundError("gallery") | ||
|
|
||
| title = re.search(r'<meta property="og:title" content="([^"]+)"/>', page).group(1) |
There was a problem hiding this comment.
I think this can be converted to:
title, pos = text.extract(page, '<meta property="og:title" content="', '"')(internally it avoids to use regular expression and that's probably faster.)
gallery_dl/extractor/imagechest.py
Outdated
| def images(self, page): | ||
| """Return a list of all (image-url, metadata)-tuples""" | ||
|
|
||
| image_keys = re.findall(r'<meta property="og:image" content="([^"]+)"/>', page) |
There was a problem hiding this comment.
I think this can be converted to:
image_keys = list(text.extract_iter(page, '<meta property="og:image" content="', '"/>'))(same rationale of previous comment)
mikf
added a commit
that referenced
this pull request
May 18, 2020
|
Ye python is not a language I'm very experienced in, sorry. Thanks for making the edits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would hold off adding additional metadata properties for this extractor since there doesn't seem to be a consistent way of grabbing stuff like view counts and descriptions right now.
I also would suggest a documentation page (or giant section of comments like youtube-dl) explaining what should be done when creating a new extractor. I essentially had to reverse engineer other extractors and common.py for example just to figure out where I was going wrong when making this.