[instagram] Add support for hashtags (InstagramTagExtractor) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thank you. According to Some minor detail, but the indentation there should only be 4 spaces, not 8. |
Add support for hashtags (TagPage-s), i.e. explore/tags/<tag> URLs. This also introduce a get_metadata() method in order to append possible further metadata per-(sub)extractor. Refactor and generalize _extract_profilepage() to _extract_page() in order to be reused by _extract_profilepage() and _extract_tagpage() simply by passing the type of page (`ProfilePage' or `TagPage') and picking up the respective fields in shared data.
|
Hello Mike,
Mike Fährmann writes:
[...]
According to `flake8` the dictionary values in lines 98-102 and 105-109 are over-indented:
```
instagram.py:98:21: E126 continuation line over-indented for hanging indent
instagram.py:105:21: E126 continuation line over-indented for hanging indent
```
Some minor detail, but the indentation there should only be 4 spaces, not 8.
[...]
Whoops, sorry! I have just fixed it - squashed the commit - and
pushed (--force(-ed)).
Thank you!
|
|
Mike Fährmann writes:
Merged #202 into master.
Thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hashtags (TagPage-s), i.e. explore/tags/ URLs.
This also introduce a get_metadata() method in order to append
possible further metadata per-(sub)extractor.
Refactor and generalize _extract_profilepage() to _extract_page()
in order to be reused by _extract_profilepage() and _extract_tagpage()
simply by passing the type of page (
ProfilePage' orTagPage') and picking upthe respective fields in shared data.