Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hitomi] fix image path #1988

Merged
merged 2 commits into from
Oct 30, 2021
Merged

[hitomi] fix image path #1988

merged 2 commits into from
Oct 30, 2021

Conversation

ombe1229
Copy link
Contributor

No description provided.

@Hrxn
Copy link
Contributor

Hrxn commented Oct 29, 2021

Again?

@mikf mikf merged commit 14852f7 into mikf:master Oct 30, 2021
@God-damnit-all
Copy link
Contributor

God-damnit-all commented Oct 30, 2021

It looks like they might have adopted something that's effectively a rotating cipher (it's not literally that in this case, but it's an apt enough comparison).

I've been seeing more and more manga sites adopting systems like this to prevent scraping. If that's what's happening here, a system to keep rotating it until it no longer 404s and then caching that offset might be needed.

Any 404 error could check the next offset before throwing the error, just in case it changes in the middle of extraction.

@Hrxn
Copy link
Contributor

Hrxn commented Oct 30, 2021

Or just extract the correct values from https://ltn.hitomi.la/common.js programmatically?

@God-damnit-all
Copy link
Contributor

God-damnit-all commented Oct 30, 2021

Or just extract the correct values from https://ltn.hitomi.la/common.js programmatically?

I didn't realize it was exposed there so that probably a better option. Either way though, it would need to be cached (if only for the duration of the extraction) and potential 404 errors would need to double check common.js.

@mikf
Copy link
Owner

mikf commented Oct 31, 2021

It looks like they might have adopted something that's effectively a rotating cipher

I don't think so, especially when the method to get the correct subdomain now is evem simpler than it was a few months ago.

Or just extract the correct values from https://ltn.hitomi.la/common.js programmatically?

Too unreliable since it would have to parse arbitrary Javascript code. If it's just simple number change like in this PR, then sure, but they usually change a bit more than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants