-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kemonoparty] Duplicate file fix #1689
Conversation
Fixes mikf#1667 Judging by the discussion in that thread, the first file is always duplicated in the attachments list, except for some posts which only have the image and no attachments. This change makes it so if attachments are present it only downloads those. It might require testing from various posts though. It worked in the one I tried for what it's worth, but I'm not too familiar with the service.
I wasn't familiar with that syntax of checking a python list's emptiness before. This should be good. |
I've also been looking for patreon posts where this wouldn't work and haven't found any for now. |
I think the shorter example for the fix you posted earlier was wrong and I applied it without thinking. I've flipped the I would have liked to add some simple test cases but I'm not familiar with Python and I'm not sure where they would go, or if you think they are necessary. |
Fixes #1667
Judging by the discussion in that thread, the first file is always duplicated in the attachments list, except for some posts which only have the image and no attachments.
This change makes it so if attachments are present it only downloads those.
It might require testing from various posts though. It worked in the one I tried for what it's worth, but I'm not too familiar with the service.