Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankaku timestamps not working #1190

Closed
cpz3501 opened this issue Dec 20, 2020 · 2 comments
Closed

Sankaku timestamps not working #1190

cpz3501 opened this issue Dec 20, 2020 · 2 comments

Comments

@cpz3501
Copy link

cpz3501 commented Dec 20, 2020

When I download from sankaku with "filename": "{created_at}.{extension}", the filenames look like this {'json_class'_ 'Time', 's'_ 1531852126, 'n'_ 0}.jpg.

@kattjevfel
Copy link
Contributor

Bisected this:

ecdea799dd71e6e9f7b28e71505be80658836138 is the first bad commit
commit ecdea799dd71e6e9f7b28e71505be80658836138
Author: Mike Fährmann <[email protected]>
Date:   Sat Dec 5 22:08:58 2020 +0100

    [sankaku] use 'beta.sankakucomplex.com' API endpoints

 gallery_dl/extractor/idolcomplex.py | 207 ++++++++++++++++++++++--
 gallery_dl/extractor/sankaku.py     | 308 ++++++++++++++----------------------
 2 files changed, 313 insertions(+), 202 deletions(-)

@mikf mikf closed this as completed in 537742c Dec 21, 2020
@mikf
Copy link
Owner

mikf commented Dec 21, 2020

So the metadata entries changed a bit when switching to the beta.sankakucomplex.com interface. 537742c changes the created_at field to be a regular timestamp again.

On a side note:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants