Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs have been fixed. Time for a 0.9.2? #654

Closed
6 tasks done
jccazeaux opened this issue Aug 7, 2016 · 19 comments
Closed
6 tasks done

Some bugs have been fixed. Time for a 0.9.2? #654

jccazeaux opened this issue Aug 7, 2016 · 19 comments

Comments

@jccazeaux
Copy link
Contributor

jccazeaux commented Aug 7, 2016

@benadamstyles
Copy link
Collaborator

Definitely! #652 is fixed now too right?

@jccazeaux
Copy link
Contributor Author

Yes, wrong issue, i meant 649.

@henkmollema
Copy link

What's the timeframe for this build? I'm hitting the bug in #650.

@benadamstyles
Copy link
Collaborator

Very soon! Today, I hope.

@henkmollema
Copy link

Great! 😄

@benadamstyles
Copy link
Collaborator

Ok @jccazeaux I think I'm ready to publish 0.9.2. You happy for me to go ahead?

@jccazeaux
Copy link
Contributor Author

Yes !
I'll work on doc ASAP. Let's not reproduce the lag we had in 0.9.0

@benadamstyles
Copy link
Collaborator

Great, once docs are merged I'll release.

@jccazeaux
Copy link
Contributor Author

I sent the PR on branch gh-pages. Is it necessary to keep docs synced on master and gh-pages?

@benadamstyles
Copy link
Collaborator

I don't think so, I think it just needs to be on gh-pages. But there may be a good reason that it is on both branches that I don't know about.

@jccazeaux
Copy link
Contributor Author

I just found the doc.sh shell on master. This shell seems to automatically update gh-pages with current docs on master. For next update i'll use it !

This was referenced Aug 10, 2016
@agmonks
Copy link
Contributor

agmonks commented Aug 10, 2016

Maybe the Contributing section in the readme should be updated with how to update documents?

@jccazeaux
Copy link
Contributor Author

jccazeaux commented Aug 10, 2016

Yes, first we must try it to be certain of how it works.
I wonder if it's something for contributors or only collaborators.

@benadamstyles
Copy link
Collaborator

Ok I'm going to publish the release ASAP.

@benadamstyles
Copy link
Collaborator

Done! @henkmollema you should be good to go.

@henkmollema
Copy link

Great, thanks! I'll try it out.

@agmonks
Copy link
Contributor

agmonks commented Aug 10, 2016

@Leeds-eBooks looks live you have checked in the es6 build on master (in dist)?

@benadamstyles
Copy link
Collaborator

@agmonks Ah balls, so I have. Stupid mistake. I will push 0.9.3 without it.

@benadamstyles
Copy link
Collaborator

0.9.3 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants