Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little problems encountered #1

Closed
GoogleCodeExporter opened this issue Mar 22, 2015 · 4 comments
Closed

Little problems encountered #1

GoogleCodeExporter opened this issue Mar 22, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Im using the latest svn version (rev 43) on 64bit Fedora 12 with 
2.6.32.14-127.fc12.x86_64 kernel

I have problems with the following files:

DNS2/Updater.php & DNS2/Question.php: 
Error: Stripped "n" from domain name if it starts with "n"
Fix: Used " instead of '

DNS2/Socket/Sockets.php & DNS2/Socket/Streams.php:
Error: Had problems with an extra tcp packet when sending TCP Length alone.  
Also had a problem when sending packets larger than 256 bytes.
Fix: Included TCP Length with data packet

Attached a svn diff for the mods.

Thanks for the library!! Works great!!

Original issue reported on code.google.com by [email protected] on 27 Sep 2010 at 6:09

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for the bug report! 

Sorry it took so long to get back- I didn't have the notifications set properly.

I added in the fixes to the Updater and Question class- I must have missed that.

But I had a question about the changes to the Sockets classes- where did you 
have problems with these? I did all my testing against BIND and PowerDNS- I 
didn't notice any problems with the extra TCP packet?

Also, the patch file you sent has a bug- I default the length to the max UDP 
packet size, and then adjust it to the length on the wire if it's a TCP socket- 
in the changes in you sent, it reads before it adjusts the size- so we'd always 
be limited to a 512 byte TCP packet read.

Any more info on your test env would be great!

Thanks!

Mike

Original comment by mike.pultz on 26 Oct 2010 at 4:11

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Sorry about the bug with the reading, I completely missed that.  Luckily I 
never had an answer bigger than the 512 bytes!

I started from your code now again, and found the actual problem.  If I fix the 
"length" part of the packet, it doesnt matter if it has an extra packet or not.

Attached is the diff & tcpdump output

Thanks for the other mods!!

Original comment by [email protected] on 26 Oct 2010 at 8:09

Attachments:

@GoogleCodeExporter
Copy link
Author

Ahh- whoops! my shift operator was the wrong way-

thanks for digging that up- I've checked in a fix, and I should put out a new 
release in the next week.

Thanks!

Mike

Original comment by mike.pultz on 29 Oct 2010 at 5:15

@GoogleCodeExporter
Copy link
Author

Original comment by mike.pultz on 29 Oct 2010 at 5:17

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant