Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding with quoted-printable produces an extra CR character #1420

Closed
dalibor opened this issue Nov 4, 2020 · 1 comment
Closed

Encoding with quoted-printable produces an extra CR character #1420

dalibor opened this issue Nov 4, 2020 · 1 comment

Comments

@dalibor
Copy link
Contributor

dalibor commented Nov 4, 2020

>> p Mail.new(Mail.new(body: \n123\n123\n123").encoded).decoded
=> \r\n123\r\n123\r\n123"

(® is used to trigger quoted-printable encoding)

I believe we should revert #1208. ::Mail::Utilities.to_crlf should only be used with raw_source= i.e. when we're parsing an email (Mail.new(content)) and not when we're creating an email by specifying the body content Mail.new(body: body). I think all the problems around CR LF are because we're not distinguishing between creating and parsing emails.

@jeremy
Copy link
Collaborator

jeremy commented Mar 11, 2021

Fixed by #1210

@jeremy jeremy closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants