WIP: Allow selection of current playback item #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedevnull
force-pushed
the
mikedevnull/issue70
branch
from
0c2e5f8 to
1a20ae5
Compare
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 91.56% 93.99% +2.42%
==========================================
Files 62 62
Lines 2835 2862 +27
Branches 193 206 +13
==========================================
+ Hits 2596 2690 +94
+ Misses 237 171 -66
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
this should allow to write cleaner code, as now Subscriptions can be used in place of Optional[Subscription] and verbose "if xyz is not None" checks
mikedevnull
force-pushed
the
mikedevnull/issue70
branch
from
1a20ae5 to
1dfc881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #70