Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Bins are missing <div id="container"></div> #23

Open
arkadyp opened this issue Jul 16, 2015 · 5 comments
Open

JS Bins are missing <div id="container"></div> #23

arkadyp opened this issue Jul 16, 2015 · 5 comments

Comments

@arkadyp
Copy link

arkadyp commented Jul 16, 2015

Thanks for putting together this great tutorial! I noticed that the JS Bins seem to be missing <div id='content'></div> inside of the html. As such, all the examples start out blank until that div is added. I'd put together a pull request to try to help resolve this issue, but that isn't possible since the JS Bins' source isn't in the repo.

@mikechau
Copy link
Owner

Hi @arkadyp do you have links for the ones that appear to be broken?

Thanks for the comments!

If you like, you can create a new JS Bin and under Share, copy the Snapshot link and do a PR pointing to the new JS Bin. :)

@arkadyp
Copy link
Author

arkadyp commented Jul 16, 2015

One example is the bin for React Props.
I'm going through the tutorial now and would be more than happy to put together a PR with the other examples I find.

@mikechau
Copy link
Owner

That would be great!

However, in that example, I do see a the content div.

screenshot

But I do see that by default this JS Bin has Auto-run JS unchecked, so they would be blank until you hit Run with JS. Maybe they could be set to Auto-run JS by default or make a note about it.

@arkadyp
Copy link
Author

arkadyp commented Jul 16, 2015

I think that the issue that I was encountering is some kind of caching bug, and not an problem with the JS Bin content as I originally thought. Whenever I click on the link I posted above I'm also seeing the full html but when I was clicking on the same link from within the guide I was seeing this:

screen shot 2015-07-16 at 4 34 52 pm

Not totally sure what's going on there but I think that it makes sense to close this issue for the time being. Thanks for the quick response!

@mikechau
Copy link
Owner

I've ran into this issue as well... yeah it's a very weird bug! I'll definitely make a note about it in my next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants