Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Materialize to 1.x #699

Open
stfnio opened this issue Dec 10, 2018 · 4 comments
Open

Upgrade Materialize to 1.x #699

stfnio opened this issue Dec 10, 2018 · 4 comments

Comments

@stfnio
Copy link

stfnio commented Dec 10, 2018

Guys, are you going to upgrade your addon to materialize 1.x?
0.97 is kinda outdated.. and not backwards compatible with 1.x, that causing issues

@mike-north
Copy link
Owner

I'd love to see this land, but don't have the bandwidth to take it on myself. The change should be made in https://github.com/mike-north/ember-materialize-shim/

@jacobq
Copy link
Collaborator

jacobq commented Dec 11, 2018

@stfnio Completely agree, but as Mike's comment demonstrates, we are unfortunately very strapped for time at the moment :( (You may have noticed that I created a materialize-v1.0 branch and a "Support Materialize v1.0.0(-rc.2)" project last summer, but have not made any progress yet.)

In the ember app that I'm currently working on, I am using MaterializeCSS 1.0 and Ember 3.5 with ember-auto-import, and for the things that I needed from Materialize I opted to roll my own components for now rather than try to get things working with ember-cli-materialize due to lack of time. Of course it's my intention to tidy-up later and push everything back upstream, but I have no idea when I'll be able to help make that happen.

If you would like to help, here are some things you could do:

  • Try running the latest ember-cli-materialize with MaterializeCSS v1.x, see what breaks, and make a list here. If you identify why something breaks (e.g. API change in Materialize) and include that too that's even better.
  • Create a fork from the latest master and start rewriting components one by one so that they work with the latest materialize version. (Feel free to link here.)

See also:
#661
mike-north/ember-materialize-shim#117

@Gorzas
Copy link
Contributor

Gorzas commented Apr 17, 2019

Hi @jacobq. Any improve in the last month? We are going to try to use Materialize 1.0 in our own base code.

@Gorzas
Copy link
Contributor

Gorzas commented Apr 17, 2019

There is a list of things that get broken when updating to version 1.0: https://github.com/Dogfalo/materialize/blob/v1-dev/v1-upgrade-guide.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants