Update for newer Clang #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionKindStrings must match CodeSynthesisContext::SynthesisKind in Sema.h from Clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support templight built with current version of clang (tested at 1d39f2e5adc9fb5e0d5ec45a5ebddf1534398ff9).
Required updating InstantiationKindStrings to match CodeSynthesisContext::SynthesisKind in Sema.h from Clang (I was getting corrupted strings from indexing off the end of that array: I assumed this was the correct fix, and it seems to work now, but I have not confirmed the data is fully accurate)
Also included is some small refactoring to deduplicate the two copies of InstantiationKindStrings.
This likely will cause incorrect output when used with older versions of clang, so I'm not sure if you want this change upstream, an/or if you want to include some version disclaimers.