Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of KeePass Proxy for HIBP online check #46

Closed
magl8 opened this issue May 11, 2022 · 3 comments
Closed

Use of KeePass Proxy for HIBP online check #46

magl8 opened this issue May 11, 2022 · 3 comments

Comments

@magl8
Copy link

magl8 commented May 11, 2022

Thank you for this excellent plugin!

Using release 1.7.6, the online check fails in a proxied network because the plugin does not use the proxy setting from Keepass. Could you please use the proxy settings from Keepass (or the system proxy settings if that's easier)?
@mihaifm
Copy link
Owner

mihaifm commented May 12, 2022

I made the changes but I don't have a proxy server to test this. Can you help test it with the attached .plgx (unzip first)

HIBPOfflineCheck.zip

thanks

@magl8
Copy link
Author

magl8 commented May 17, 2022

Perfect! Works as expected with KeePass Proxy option set to "Use system Proxy settings". Thank you for the quick fix.

@mihaifm
Copy link
Owner

mihaifm commented May 18, 2022

Good stuff. I published a new release with this fix. Thanks for getting involved.

@mihaifm mihaifm closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihaifm @magl8