test regression testMethod=test_logger in 1.8.4

[anthraxx]

Hi, since 1.8.4 i encountered a regression visible through the test suite:

============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-3.3.1, py-1.5.0, pluggy-0.6.0
rootdir: /build/python-socketio/src/python-socketio-1.8.4, inifile:
collected 274 items

tests/test_asyncio_manager.py ........................                   [  8%]
tests/test_asyncio_namespace.py ............                             [ 13%]
tests/test_asyncio_pubsub_manager.py ........................            [ 21%]
tests/test_asyncio_redis_manager.py ..........                           [ 25%]
tests/test_asyncio_server.py ........................................... [ 41%]
..F..........                                                            [ 45%]
tests/test_base_manager.py ........................                      [ 54%]
tests/test_middleware.py ...                                             [ 55%]
tests/test_namespace.py ...........                                      [ 59%]
tests/test_packet.py ................................                    [ 71%]
tests/test_pubsub_manager.py ........................                    [ 80%]
tests/test_server.py ...........................................F....... [ 98%]
...                                                                      [100%]

=================================== FAILURES ===================================
_________________________ TestAsyncServer.test_logger __________________________

self = <tests.test_asyncio_server.TestAsyncServer testMethod=test_logger>
eio = <MagicMock name='AsyncServer' id='105862967207136'>

    def test_logger(self, eio):
        s = asyncio_server.AsyncServer(logger=False)
>       self.assertEqual(s.logger.getEffectiveLevel(), logging.ERROR)
E       AssertionError: 0 != 40

tests/test_asyncio_server.py:545: AssertionError
____________________________ TestServer.test_logger ____________________________

self = <tests.test_server.TestServer testMethod=test_logger>
eio = <MagicMock name='Server' id='105862968100344'>

    def test_logger(self, eio):
        s = server.Server(logger=False)
>       self.assertEqual(s.logger.getEffectiveLevel(), logging.ERROR)
E       AssertionError: 0 != 40

tests/test_server.py:459: AssertionError

[miguelgrinberg]

That's weird. There were no logging changes in 1.8.4, and besides, that test continues to pass on Travis.

[anthraxx]

@miguelgrinberg interesting, not sure why, maybe because of some kind of stdout hooking, but using pytest to run the tests leads to this behavior while using setup.py test lets it pass

[miguelgrinberg]

But you are saying that with 1.8.3 still under pytest this test did not fail?

[anthraxx]

@miguelgrinberg apparently this is a feature since pytest 3.3.0 named catchlog and socketio 1.8.3 was back then build with pytest 3.2.x
https://github.com/pytest-dev/pytest/blame/master/CHANGELOG.rst#L113
pytest-dev/pytest#2794

[miguelgrinberg]

This issue will be automatically closed due to being inactive for more than six months. Seeing that I haven't responded to your last comment, it is quite possible that I have dropped the ball on this issue and I apologize about that. If that is the case, do not take the closing of the issue personally as it is an automated process doing it, just reopen it and I'll get back to you.