Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move .md files to published package #85

Merged
merged 1 commit into from
Apr 12, 2022
Merged

move .md files to published package #85

merged 1 commit into from
Apr 12, 2022

Conversation

SergeAstapov
Copy link
Collaborator

This moves README.md, LICENSE.md and CHANGELOG.md from the
repository root into the ./addon directory.

In doing so, the three files will be picked up by npm pack and
npm publish respectively, so that the npmjs.com listing shows
the proper README.md instead of an error message, and so that these
files are also available in the users node_modules.

It also adds symlinks from the old location to the new location, so that
GitHub still renders the repository overview correctly. It's important,
that the files are physically moved instead of just symlinked into the
package, as npm pack doesn't follow symlinks.

CONTRIBUTING.md is intentionally not moved, as it's only relevant in
the context of the repository.

This moves `README.md`, `LICENSE.md` and `CHANGELOG.md` from the
repository root into the `./addon` directory.

In doing so, the three files will be picked up by `npm pack` and
`npm publish` respectively, so that the [npmjs.com listing][1] shows
the proper `README.md` instead of an error message, and so that these
files are also available in the users `node_modules`.

It also adds symlinks from the old location to the new location, so that
GitHub still renders the repository overview correctly. It's important,
that the files are physically moved instead of just symlinked into the
package, as `npm pack` doesn't follow symlinks.

`CONTRIBUTING.md` is intentionally not moved, as it's only relevant in
the context of the repository.

[1]: https://www.npmjs.com/package/ember-css-transitions
@miguelcobain miguelcobain merged commit 375baf8 into miguelcobain:master Apr 12, 2022
@SergeAstapov SergeAstapov deleted the include-md-files-in-package branch April 12, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants