Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group 4A missing TP and PTY #110

Open
KubaPro010 opened this issue May 16, 2024 · 1 comment
Open

Group 4A missing TP and PTY #110

KubaPro010 opened this issue May 16, 2024 · 1 comment

Comments

@KubaPro010
Copy link

KubaPro010 commented May 16, 2024

When checking out the code of my rpitx2 rds generator (and implementing my python rds encoder, rdPy), i've stumbled opun a bug in the 4A group generation, the code sets blocks[1] which should contain the TP and PTY and something else which is not important now, (https://github.com/miegl/PiFmAdv/blob/master/src/rds.c#L88) we set it to what the 4A group needs, however we are missing the PTY and TP

EDIT: also something with 4A but not the blocks, but is the mjd generation correct? the mon+2 part seems incorrect as the rds docs say it should be mon+1 instead

@KubaPro010
Copy link
Author

KubaPro010 commented May 16, 2024

I've also now concluded why it doesnt have tp or pty, because it was untouched since pifmrds from 6+ years ago, nothing was changed since by anyone, pifmrds didnt have tp or pty or af, it was extremely basic for the group gen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant