Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): update types of utils.ts #259

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Jul 1, 2019

ref: #258

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

给 packages/midway-web/src/utils.ts 增加类型

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #259 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   88.47%   88.49%   +0.01%     
==========================================
  Files          35       35              
  Lines         668      669       +1     
  Branches       43       44       +1     
==========================================
+ Hits          591      592       +1     
  Misses         68       68              
  Partials        9        9
Impacted Files Coverage Δ
packages/midway-web/src/utils.ts 100% <100%> (ø) ⬆️
packages/midway-web/src/loader/webLoader.ts 90.9% <85.71%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b9fb...fb534bb. Read the comment docs.

@waitingsong waitingsong force-pushed the types branch 2 times, most recently from 08e08a0 to ffd65ef Compare July 1, 2019 11:49
@czy88840616 czy88840616 merged commit b7d478a into midwayjs:master Jul 1, 2019
@waitingsong waitingsong deleted the types branch July 1, 2019 15:48
czy88840616 pushed a commit that referenced this pull request Jul 1, 2019
feat(types): update types of utils.ts (#259)

feat(types): update types of utils.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants