Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): options to minify all products #389

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

legendecas
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

midway-bin

Description of change

Add option to minify built products.

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #389 into master will decrease coverage by 1.03%.
The diff coverage is 65.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   90.59%   89.56%   -1.04%     
==========================================
  Files          36       36              
  Lines         808      843      +35     
  Branches       48       48              
==========================================
+ Hits          732      755      +23     
- Misses         66       78      +12     
  Partials       10       10
Impacted Files Coverage Δ
packages/midway-bin/lib/cmd/build.js 85.47% <65.71%> (-8.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a008af...72f1b36. Read the comment docs.

@legendecas legendecas changed the base branch from 2.x to master February 17, 2020 06:21
@czy88840616 czy88840616 merged commit 86d5279 into midwayjs:master Feb 17, 2020
czy88840616 pushed a commit that referenced this pull request Feb 17, 2020
feat(build): options to minify all products (#389)
czy88840616 pushed a commit that referenced this pull request Feb 17, 2020
@legendecas legendecas deleted the minify branch March 4, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants