Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- tsconfig-test-development.json - added isolatedModules: true #1661

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mehonja
Copy link

@mehonja mehonja commented Apr 1, 2024

Motivation

#1535

Test plan

All tests work, added isolatedModules to development tests.

Closing issues

Fixes #1535

Types of changes

-> Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

- fixed all errors result the isolated modules
- moved types and data reexports to separate exports
@mehonja mehonja requested a review from a team as a code owner April 1, 2024 12:54
@mehonja
Copy link
Author

mehonja commented Apr 1, 2024

@microsoft-github-policy-service agree

@Overdash
Copy link

Overdash commented Jul 1, 2024

Any update on this PR? This typescript issue seems to affect Next.js 14 projects since isolatedModules is recommended to be set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS1205 Re-exporting in /src/authentication/azureTokenCredentials/index.ts:7:10
3 participants