Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📢 Inaccurate Odata type information causing POST/PATCH/PUT to fail #217

Closed
baywet opened this issue Jul 14, 2022 · 2 comments · Fixed by #222
Closed

📢 Inaccurate Odata type information causing POST/PATCH/PUT to fail #217

baywet opened this issue Jul 14, 2022 · 2 comments · Fixed by #222
Assignees
Labels
bug Something isn't working fixed

Comments

@baywet
Copy link
Member

baywet commented Jul 14, 2022

Starting at version 0.27.0 to 0.30.0 the Odata type property on models might be inaccurate (e.g. User has an OData type of #microsoft.graph.directoryObject instead of #microsoft.graph.user) which causes some write operations to fail.

The error message might or might not reflect that aspect, it depends on the target API.

We're working to fix the issue in the conversion library where it comes from so the information is accurate in this SDK.

In the meantime you can either:

  • stick to version 0.26.0 with the drawback that some API paths/models will be missing and some other bugs that are now fixed are going to be present
  • add a model.SetType(nil) line before the failing POST/PATCH/PUT operations (GET/DELETE not impacted)

We'll close this issue when the situation is resolved. Thanks to @abjoseph for reporting this on #212

@baywet baywet added the bug Something isn't working label Jul 14, 2022
@baywet baywet self-assigned this Jul 14, 2022
@baywet baywet pinned this issue Jul 14, 2022
@baywet
Copy link
Member Author

baywet commented Jul 14, 2022

Also, due to further discussions the SetType method will become SetOdataType by version 0.31.0

@baywet
Copy link
Member Author

baywet commented Aug 16, 2022

closing as fixed by #222

@baywet baywet closed this as completed Aug 16, 2022
@baywet baywet unpinned this issue Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant