Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch "response" semantics are confusing #250

Open
eric-millin opened this issue Dec 4, 2023 · 1 comment
Open

Batch "response" semantics are confusing #250

eric-millin opened this issue Dec 4, 2023 · 1 comment
Assignees
@rkodev

Comments

@eric-millin
Copy link
Contributor

Not a huge deal, but something to think about for v2.

The Batch API is confusing when dealing with BatchItem and BatchResponse. Response is overloaded as it refers to both the response to the top-level batch response and the collection of responses that it contains. Then GetResponses returns BatchItem. Functions operating on the BatchItem treat it as a "response". I've had moments of trying to keep everything straight. Could use clarifying. Thanks
@eric-millin
Copy link
Contributor Author

Occurred to me that distinguishing Batched items from Batch might help.

@rkodev rkodev self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkodev rkodev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkodev @eric-millin