Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OData query parameters for v1 fail because of missing $ sign #2

Closed
Tracked by #1
baywet opened this issue Oct 22, 2021 · 0 comments
Closed
Tracked by #1

OData query parameters for v1 fail because of missing $ sign #2

baywet opened this issue Oct 22, 2021 · 0 comments
Assignees

Comments

@baywet
Copy link
Member

baywet commented Oct 22, 2021

The typical URL template look something like

https://graph.microsoft.com/v1.0/users{?select,expand,orderby,top}

and will resolve to something like

https://graph.microsoft.com/v1.0/users?select=displayName

This is not an issue in beta because the service doesn't require the dollar sign. However it is an issue in v1.0 because the dollar sign is required.
The service will either ignore the query string parameter or fail, depending on the backend workload.

We can't use the dollar sign in the url template as it is not allowed by the specification.
The service is not planning to remove that requirement as it might break some existing applications.

The solution would be to add a middleware to do string replacement of those values and insert the dollar sign before executing the request.

@baywet baywet mentioned this issue Oct 22, 2021
25 tasks
@baywet baywet self-assigned this Oct 22, 2021
@baywet baywet closed this as completed in c4cbb8b Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant