Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release please configuration #940

Closed
8 of 9 tasks
baywet opened this issue May 2, 2024 · 3 comments · Fixed by #952
Closed
8 of 9 tasks

add release please configuration #940

baywet opened this issue May 2, 2024 · 3 comments · Fixed by #952
Assignees
Labels
enhancement New feature or request

Comments

@baywet
Copy link
Member

baywet commented May 2, 2024

reflect the following changes
microsoftgraph/msgraph-sdk-java#1964
microsoftgraph/msgraph-sdk-java#1946
microsoftgraph/msgraph-sdk-java#1944
microsoftgraph/msgraph-sdk-java#1939

We want:

  • release please header file (yaml .github/release-please.yml)
  • release please manifest (json .release-please-manifest.json)
  • release please config (json release-please-config.json)
  • release please workflow to trigger on main branch (.github/workflows/release-please.yml) Using the release please GitHub app doesn't require this.
  • release please secret setup RELEASE_PLEASE_TOKEN install the release please GitHub app to the repository
  • changelog keep a changelog header and unreleased information to be removed
  • contributing to be updated with commit formatting instructions
  • version bump script to be deleted (and removed from the weekly generation process)
  • files where the version needs to be updated to be ammended with the special comments for release please
@baywet baywet added the enhancement New feature or request label May 2, 2024
@baywet baywet transferred this issue from microsoftgraph/msgraph-beta-sdk-python May 2, 2024
@Ndiritu Ndiritu self-assigned this May 7, 2024
@sebastienlevert
Copy link

Add full documentation of the release process

@calebkiage
Copy link

calebkiage commented May 9, 2024

We don't need to set the RELEASE_PLEASE_TOKEN anymore since we're using a GitHub app. We just need to install the app in a repository. I've deleted the secret from the microsoftgraph/msgraph-sdk-java repository to avoid confusion.

@baywet
Copy link
Member Author

baywet commented May 9, 2024

Thanks for the additional information here. FYI I created all the install requests issues with the OSPO (see timeline on this and related issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants