Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: TorProject.TorBrowser version 11.0.4 #40730

Merged

Conversation

OfficialEsco
Copy link
Contributor

@OfficialEsco OfficialEsco commented Jan 13, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label Jan 13, 2022
@ghost
Copy link

ghost commented Jan 13, 2022

Hello @OfficialEsco,
When processing this package, the URL to the installer returned a 404 error or was determined to be invalid.

Please update the URL and hash at your convenience and resubmit your PR.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 13, 2022
@OfficialEsco
Copy link
Contributor Author

Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_en-US.exe
Result: Download Failed

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 14, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 14, 2022
@Yolgie
Copy link
Contributor

Yolgie commented Jan 20, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 40730 in repo microsoft/winget-pkgs

@Yolgie
Copy link
Contributor

Yolgie commented Jan 20, 2022

all downloads in the manifest work for me, can the automatic check be restarted?

@OfficialEsco
Copy link
Contributor Author

The error is most likely caused by the Azure Pipeline getting blocked by visiting the website too much, one download will timeout every time

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Error-Installer-Availability The installer was not available to validate (HTTP Issue) Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 20, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label Jan 20, 2022
@ghost
Copy link

ghost commented Jan 20, 2022

Hello @OfficialEsco,
When processing this package, the URL to the installer returned a 404 error or was determined to be invalid.

Please update the URL and hash at your convenience and resubmit your PR.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 20, 2022
@OfficialEsco
Copy link
Contributor Author

As you can see ¯\_(ツ)_/¯

-----------------------------------------------------
Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe
Result: Download Failed
-----------------------------------------------------
Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe
Result: Download Failed
-----------------------------------------------------
1/20/2022 7:49:51 PM
Status: Completed
##[error] Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe
##[error] Result: Failed
##vso[task.logissue type=error] Error occurred while downloading installer from https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe. 0x80072EE2.
Error information: 
Http Response: OK
Http Reason Phrase: OK

1/20/2022 7:49:51 PM
Status: Completed
##[error] Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe
##[error] Result: Failed
##vso[task.logissue type=error] Error occurred while downloading installer from https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe. 0x80072EE2.
Error information: 
Http Response: OK
Http Reason Phrase: OK

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 20, 2022
@Yolgie
Copy link
Contributor

Yolgie commented Jan 20, 2022

hmmm, I can't imagine this is the only software affected, what would have to be changed to fix this, maybe update the pipeline to not download everything at the same time but stagger it a little? If the pipeline takes a few minutes longer for manifests with many links that would not be a big problem right?

@Yolgie
Copy link
Contributor

Yolgie commented Jan 22, 2022

Created a discussion here: #41662 maybe you have other ideas how to solve this :)

@OfficialEsco
Copy link
Contributor Author

Created a discussion here: #41662 maybe you have other ideas how to solve this :)

Already saw it and upvoted it :)
Waiting for MS to reply since the bots are closed source, calibre might have a similar issue, however over multiple manifests

@denelon
Copy link
Contributor

denelon commented Feb 12, 2022

/azp run

@ghost ghost removed Error-Installer-Availability The installer was not available to validate (HTTP Issue) Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 12, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 12, 2022
@ghost
Copy link

ghost commented Feb 12, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Feb 12, 2022

Hello @OfficialEsco,
Validation has completed.

@ghost ghost merged commit 348d92b into microsoft:master Feb 12, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@OfficialEsco OfficialEsco deleted the TorProject.TorBrowser-11.0.4-7678FD4 branch February 12, 2022 11:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants