Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move: rhysd.actionlint version 1.6.24 #101511

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Move: rhysd.actionlint version 1.6.24 #101511

merged 1 commit into from
Apr 18, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Apr 4, 2023 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with Komac v1.4.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sitiom sitiom mentioned this pull request Apr 4, 2023
Merged
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 4, 2023
@BrandonWanHuanSheng
Copy link
Contributor

@stephengillie It look like this PR is needed manual review.

@stephengillie
Copy link
Collaborator

Manual Validation failed with:

2023-04-04 08:51:14.290 [FAIL] Installer failed security check. Url: https://github.com/rhysd/actionlint/releases/download/v1.6.24/actionlint_1.6.24_windows_386.zip Result: 0x80004005

@sitiom
Copy link
Contributor Author

sitiom commented Apr 4, 2023

What's that supposed to mean? False positive?

@stephengillie
Copy link
Collaborator

What's that supposed to mean? False positive?

From #101324 (comment)

The "failed security check" is usually defender / smartscreen flagging the URL as an unknown / potentially malicious URL before the download ever completes

@sitiom sitiom closed this Apr 5, 2023
@sitiom sitiom reopened this Apr 5, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 5, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 5, 2023
@BrandonWanHuanSheng
Copy link
Contributor

But I download from Microsoft Edge is not flagged as malicious.
Screenshot (146)

@sitiom sitiom mentioned this pull request Apr 15, 2023
Merged
@sitiom sitiom changed the title New version: rhysd.actionlint version 1.6.24 Move: rhysd.actionlint version 1.6.24 Apr 15, 2023
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 170187fcb01b7d21b5d25d42dc1beb5da32e5fe3dd04e9433cb641ca1a2191e4
    • manifests\r\rhysd\actionlint\v1.6.24
  • InstallerSha256: c874d0074f277cde608033e84668e78483f31b46d384cce8f49cda49a56e3217
    • manifests\r\rhysd\actionlint\v1.6.24
  • InstallerSha256: b3f43e3fd5a30785f9b9d4a495a7164870698b6a8f072bbd0503e70ef2735f8b
    • manifests\r\rhysd\actionlint\v1.6.24

@sitiom sitiom closed this Apr 17, 2023
@sitiom sitiom reopened this Apr 17, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 17, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 17, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Apr 17, 2023

@microsoft-github-policy-service
Copy link
Contributor

sitiom,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 13055b5 into microsoft:master Apr 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 18, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@sitiom sitiom deleted the rhysd.actionlint-1.6.24-D8460DB76B7551C0641DE56B5B95A4ED branch April 19, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sitiom @wingetbot @BrandonWanHuanSheng @stephengillie @msftrubengu @AmelBawa-msft