Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest Validation: Failed to process installer (MSIX only) #79677

Closed
2 tasks done
AmelBawa-msft opened this issue Sep 15, 2022 · 7 comments
Closed
2 tasks done

Manifest Validation: Failed to process installer (MSIX only) #79677

AmelBawa-msft opened this issue Sep 15, 2022 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@AmelBawa-msft
Copy link
Contributor

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

MSIX Manifest installer validation fails for certain installers when attempting to stream the MSIX info from the installer URL during the validation.

Steps to reproduce

#75891

Actual behavior

Manifest installer validation fails to get the MSIX info for certain installers.

Expected behavior

Manifest installer validation should be able to get the MSIX info for all (MSIX) installers.

Environment

WinGetUtil

Screenshots and Logs

No response

@AmelBawa-msft AmelBawa-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 15, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 15, 2022
@denelon denelon removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 15, 2022
@Jaifroid
Copy link
Contributor

Jaifroid commented Oct 5, 2022

@AmelBawa-msft @denelon I'm getting the same unexpected failure for the latest version of WikiMed (#82540), which I just submitted. I traced my way to this issue by looking for other PRs with the same Manifest-Installer-Validation-Error label, and finding the discussion in #75891. Thank you for creating an issue for that.

Is there any timeline on when this blocker might be addressed? Because it seems I can no longer upload the latest WikiMed manifests to winget. Please note that even if the manifest validation error is solved, we still have the issue that large (>1GB) msix/appxbundle packages from GitHub (at least) fail to install in winget locally (see screenshot), whereas small ones install fine. It may be a related issue. Unkown error 0x80072eff is produced now whenever I try to install WikiMed via winget, whereas the smaller version of the same package, only without the compressed WikiMed archive, Kiwix.KiwixJS (~12MB) installs fine. So the size of the bundle seems to have something to do with this error.

image

@denelon
Copy link
Contributor

denelon commented Oct 6, 2022

@Jaifroid @AmelBawa-msft is looking at this issue, we've got a couple of approaches we're looking at. The issue is related to servers not honoring the call that we make when we try to validate without a full download. I would expect we will have this resolved before the 1.4 client is GA. This fix does not depend on that release per se' but we may have client improvements as well as service improvements.

@denelon
Copy link
Contributor

denelon commented Oct 7, 2022

@Jaifroid how often do you have updates? I want to try and help get these validated manually until the fix is in.

@Jaifroid
Copy link
Contributor

Jaifroid commented Oct 7, 2022

@denelon Thank you for the updates. The Kiwix.WikiMed app (~1.3GB) is updated monthly, around the beginning of each month. The Kiwix.Wikivoyage app (also affected because it is ~660MB) is updated monthly around the middle of the month. The base Kiwix.KiwixJS app isn't affected because it is much smaller (~12MB). All the packages are hosted on GitHub releases. The reason for the monthly cycle is that it corresponds to the release of updated content by Kiwix org.

@denelon
Copy link
Contributor

denelon commented Oct 7, 2022

Thanks @Jaifroid. That helps, and hopefully we only have one or two more times we'll need to validate manually.

@Jaifroid
Copy link
Contributor

Same error 0x80072eff : unknown error happening with Kiwix.Wikivoyage, with installer 2.1.9, which I just got validated:

PS C:\Repos> winget update kiwix.wikivoyage
Found Wikivoyage by Kiwix [Kiwix.Wikivoyage] Version 2.1.9.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
An unexpected error occurred while executing the command:
0x80072eff : unknown error

The funny thing is, this one passed installation validation on your end, but in real-world usage, winget fails to install it on a fully up-to-date modern machine.

@Trenly
Copy link
Contributor

Trenly commented May 1, 2024

@AmelBawa-msft - I believe this issue has been addressed as there have been several updates to the validation pipeline since the issue was opened. If it is not resolved, it would be extremely helpful if a new issue could be opened pointing to a the new failure.

Close with reason: Stale;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants