Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Move Neotys.NeoLoad to Tricentis.NeoLoad #66937

Closed
2 tasks done
mdanish-kh opened this issue Jul 20, 2022 · 6 comments
Closed
2 tasks done

[Package Issue]: Move Neotys.NeoLoad to Tricentis.NeoLoad #66937

mdanish-kh opened this issue Jul 20, 2022 · 6 comments
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Jul 20, 2022

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Neotys has been acquired by Tricentis and new versions (7.8.1 onwards) of Neotys.NeoLoad have Tricentis in the publisher field instead of Neotys.

image

Should I move this 8.0.0 manifest from Neotys.NeoLoad to Tricentis.NeoLoad (and update its metadata) and add newer versions in the new directory? Or should I add the newer versions in the old directory?

Secondly (if moderators approve the move), what about the old versions (7.3 to 7.8.1) present in Neotys.NeoLoad directory? Should we get rid of them or should they remain in the old directory? They might be a cause of confusion for the user as then two same packages would be under different publisher directories.

Steps to reproduce

.

Actual behavior

.

Expected behavior

.

Environment

.

Screenshots and Logs

No response

@mdanish-kh mdanish-kh added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 20, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 20, 2022
@Trenly
Copy link
Contributor

Trenly commented Jul 20, 2022

I would actually leave the 8.0.0 manifest in the Neotys folder, with the incorrect metadata. Specifically, I would update everything except for the publisher, even going so far as to add AppsAndFeaturesEntries with the incorrect publisher value

Then, I would create a copy of the 8.0.0 manifest in the Tricentis folder, and make sure the AppsAndFeaturesEntries and all other metadata is correct.

Although I haven’t verified, this should cause anyone on Neotys.NeoLoad < 8.0.0 to be updated to Neotys.NeoLoad 8.0.0; But, once updated, the AppsAndFeaturesEntries should now match the new package - Tricentis.NeoLoad, and new versions will follow the updates from the new publisher folder

@denelon
Copy link
Contributor

denelon commented Jul 20, 2022

@Trenly

I agree with your suggestion. This process would help considerably. Our longer-term solution is likely to be a combination of:

I've seen this come up a few times now. I'm not sure where the best place is to document this as a recommended practice. Maybe it's time for an F.A.Q. What are your thoughts on this?

@Trenly
Copy link
Contributor

Trenly commented Jul 20, 2022

@Trenly

I agree with your suggestion. This process would help considerably. Our longer-term solution is likely to be a combination of:

I've seen this come up a few times now. I'm not sure where the best place is to document this as a recommended practice. Maybe it's time for an F.A.Q. What are your thoughts on this?

I think an FAQ would be good; I think special topics of interest would be Publisher changes / acquisitions as mentioned here, Zip support, Common causes of “No installed package found matching criteria” when trying to upgrade, What is an ARP Entry, Issues with Unknown package version, issues with Disambiguation of side-by-side installs (VC++ / Dotnet), etc.

If there were a central place like an FAQ that we could reference to all of the “common issues” that we see, it would be great.

I propose we use our Blind Pair Programming group on Gitter to gather opinions, then I can create a draft markdown file and we can get it published

@denelon denelon added Help-Wanted This is a good candidate work item from the community. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jul 20, 2022
@mdanish-kh
Copy link
Contributor Author

Resolved through #66947 and #66948. This may be closed if it needs no further discussion.

@denelon
Copy link
Contributor

denelon commented Jul 21, 2022

We now have an F.A.Q thanks to @Trenly.

@denelon denelon closed this as completed Jul 21, 2022
@Trenly
Copy link
Contributor

Trenly commented Jul 21, 2022

Just leaving this here - Validated the transition is working as expected:

PS C:\Windows\system32> winget show Neotys.Neoload --versions
Found NeoLoad [Neotys.NeoLoad]
Version
-------
8.0.0
7.8.1
7.7.0
7.6.0
7.5.1
7.4.0
7.3
PS C:\Windows\system32> winget install Neotys.NeoLoad -v 7.8.1
Found NeoLoad [Neotys.NeoLoad] Version 7.8.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://d24mnm5myvorwj.cloudfront.net/documents/download/neoload/v7.8/neoload_7_8_1_windows_x64.exe
  ██████████████████████████████   360 MB /  360 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Windows\system32> winget list NeoLoad
Name    Id             Version Available
----------------------------------------
NeoLoad Neotys.NeoLoad 7.8.1   8.0.0
PS C:\Windows\system32> winget upgrade Neotys.NeoLoad
Found NeoLoad [Neotys.NeoLoad] Version 8.0.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://d24mnm5myvorwj.cloudfront.net/documents/download/neoload/v8.0/neoload_8_0_0_windows_x64.exe
  ██████████████████████████████   358 MB /  358 MB
Successfully verified installer hash
Starting package uninstall...
Successfully uninstalled
Starting package install...
Successfully installed
PS C:\Windows\system32> winget list NeoLoad
Name    Id                Version
---------------------------------
NeoLoad Tricentis.NeoLoad 8.0.0
PS C:\Windows\system32> winget -v
v1.2.10271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants