Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corsair.iCue manifest improvement #64180

Open
denelon opened this issue Jun 22, 2022 · 0 comments
Open

Corsair.iCue manifest improvement #64180

denelon opened this issue Jun 22, 2022 · 0 comments
Labels
Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version)

Comments

@denelon
Copy link
Contributor

denelon commented Jun 22, 2022 •
edited
Loading

Corsair iCue "might" be willing to give a custom return code so we can inform the user a reboot is required with expected return codes:
https://github.com/microsoft/winget-cli/blob/9056c0fc3fe4a362ef2644ba080f88698836576b/schemas/JSON/manifests/v1.2.0/manifest.installer.1.2.0.json#L172-L201

Otherwise, we would need add "post install display notes" to the manifest:

Originally posted by @denelon in microsoft/winget-cli#1009 (comment)
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 22, 2022
@denelon denelon added Package-Request This is a request for a package (new or updated version) Help-Wanted This is a good candidate work item from the community. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denelon