Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: NickeManarin.ScreenToGif Does Not Upgrade Existing Installations #58993

Closed
2 tasks done
phuzion opened this issue Apr 28, 2022 · 14 comments
Closed
2 tasks done
Labels
Area-External Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@phuzion
Copy link
Contributor

phuzion commented Apr 28, 2022

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

When upgrading to a new version of ScreenToGif, if the original version was installed outside of winget, an additional copy will be installed, rather than upgrading the existing copy. Since the old version remains, winget upgrade always shows an outdated copy of ScreenToGif in the upgrade candidates list.

I'm not 100% sure if this qualifies as a side-by-side installation or not, so I'm classifying this under the more generic installation issue tag. Please re-tag as appropriate.

Steps to reproduce

  • Install any old version of ScreenToGif interactively using the MSI file provided in the manifest
  • Run winget upgrade and see that ScreenToGif is listed as a possible upgrade
  • Run winget upgrade NickeManarin.ScreenToGif and allow the upgrade to occur
  • Note in appwiz.cpl that there are two versions of ScreenToGif installed

Actual behavior

Two versions of the application appear in Programs and Features

Expected behavior

The old copy of ScreenToGif should be upgraded rather than have a second copy installed.

Environment

Windows Package Manager v1.2.10271
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1645
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs

No response

@phuzion phuzion added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 28, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Apr 28, 2022
@denelon
Copy link
Contributor

denelon commented Apr 28, 2022

@phuzion,

I'm not sure if this is an issue with interactive install vs. silent due to the MSI from ScreenToGif, or if the manifest needs to be augmented with the additional data to help map with Windows Apps & Features.

Which version of ScreenToGif did you perform the interactive install from? Was this a download the installer and double click first, or did you run winget install ScreenToGif --version <some version> --interactive?

I'd like to be able to reproduce this and capture logs, so we can see if there is something we can fix on our end on the client, or the manifest. Otherwise, we might need to see what could be done in the MSI from ScreenToGif.

@NickeManarin,

Have you encountered this before?

@denelon denelon removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Apr 28, 2022
@phuzion
Copy link
Contributor Author

phuzion commented Apr 28, 2022

I originally installed ScreenToGif 2.33.1 from an MSI. When I say interactive, I mean that I downloaded and opened the MSI and clicked through the wizard steps.

If there's anything I can do on my end to assist (collecting logs, etc), please let me know.

@denelon
Copy link
Contributor

denelon commented Apr 28, 2022

@phuzion
Copy link
Contributor Author

phuzion commented Apr 28, 2022

Out of curiosity, I installed ScreenToGif 2.33.0 using the MSI and clicking through the wizard, and then upgraded to versions 2.35.0 and 2.36.0, and there was no duplication in Programs and Features.

After uninstalling 2.36.0 through Programs and Features, manually reinstalling 2.35.0, and then attempting an upgrade using winget upgrade ScreenToGif, I continue to see the duplicate entry in Programs and Features.

@NickeManarin
Copy link
Contributor

This was an issue with older versions of the MSI package. It should not happen with newer version.
The app supports perUser/perMachine installations.

@phuzion
Copy link
Contributor Author

phuzion commented Apr 28, 2022

@NickeManarin Could you please clarify, are you saying that this issue is fixed in 2.36.0 or a prior version? I'm still seeing the duplicate entry in Programs and Features when doing a manual installation of 2.35.4 via MSI, and then an upgrade to 2.36.0 with winget upgrade ScreenToGif.

I just want to make sure we're on the same page.

My biggest concern is that if it's just an issue that's fixed for 2.36.0 and future versions, we will likely need to develop a workaround for users who have installed a prior version manually and wish to use winget to upgrade their apps moving forward.

@NickeManarin
Copy link
Contributor

NickeManarin commented Aug 14, 2022

@phuzion Sorry for the delay.

Let me clarify what I wrote before:

The installer lets you install in perUser/perMachine modes via user selection in the UI (this was not available before; I think that it was set as perMachine).
Of course, when installing perMachine in version 2.35 and then later trying to install perUser in 2.36 you would get two entries in the program list.
Newer installers (after v2.36) will handle that (uninstalling the version regardless of the installation mode) when running manually.

But if the installer is triggered by a tool (via msiexec), you still need to uninstall the other version manually.

@bartoszek
Copy link

The issue persist with NickeManarin.ScreenToGif:2.37.1
After upgrading from 2.37 to 2.37.1 winget alongside control_panel/add_remove_program shows both version being installed.

winget list|Select-String ScreenToGif                                                                                                                                  in pwsh at 13:34:14

ScreenToGif                               NickeManarin.ScreenToGif                  2.37.1                       winget
ScreenToGif                               NickeManarin.ScreenToGif                  2.37           2.37.1        winget

@edler-san
Copy link

Same for 2.37.2 to 2.3.38.

@denelon
Copy link
Contributor

denelon commented May 27, 2023

@NickeManarin any ideas? Did something change?

@denelon
Copy link
Contributor

denelon commented May 27, 2023

@NickeManarin sorry, the issue didn't refresh for me correctly. I saw your comments after I posted :(

@denelon
Copy link
Contributor

denelon commented May 27, 2023

If there aren't any settings that persist, we could add "uninstallPrevious" for newer manifests for a while to help.

Copy link
Contributor

Hello @phuzion,

This issue has been identified as requiring a fix from a third party or external repository. Since there has been no recent activity on this issue, it will be automatically closed.

Template: msftbot/noRecentActivity/areaExternal

1 similar comment
Copy link
Contributor

Hello @phuzion,

This issue has been identified as requiring a fix from a third party or external repository. Since there has been no recent activity on this issue, it will be automatically closed.

Template: msftbot/noRecentActivity/areaExternal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

5 participants