-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature]: Moving VC++ Redist manifests #41216
Comments
I think this is a good plan, i can't recall if we will be able to have dependency architectures in the same manifest later, but if we can we would have to restructure anyways |
We (hopefully) will, I made an issue for it: microsoft/winget-cli#1665 No comments from the team on it yet, but it will probably not be present until a hypothetical schema 1.2 (and who knows when that will happen), so I think it's safe to move stuff how we want for now. |
How much work would it take to bind the |
I haven't looked into it much but I don't think it would be that hard. I'm not sure how extensible those code paths are, next time I have the codebase open I'll take a peek.
I figured the schemas were pretty much frozen unless there was a bug, but I don't know. @denelon, thoughts? |
I am moving the package identifiers. Will replace dependencies once PRs gets merged. |
IMO as of right now there is no reason to accept the new package identifier as it will only make it so there are more PRs and the only pro being a "cleaner" structure edit: well, its not tooooo bad https://github.com/microsoft/winget-pkgs/search?q=PackageDependencies%3A+Microsoft.VC%2B%2B |
Can we hold on moving stuff until we’re sure we can’t make more changes to 1.1? There’s no point in moving them now unless we won’t have the schema change for a while (like months). |
There were several "big" things added to the 1.1 schema, and we still have plenty that isn't implemented. Unless we run into some kind of trouble, I'm not expecting much to change in the schema any time soon. |
Another question is: |
AFAIK 2019 and 2022 is the same, or atleast 2022 uninstalls 2019 before installing, would it break and confuse people if it was Microsoft.VC++2015+Redist? I think the install would break if a dependency called for 2015-2019 when 2015-2022 is installed |
Manifests have been separated into Microsoft.VCRedist.. Close with reason: Completed; |
Description of the new feature/enhancement
Is it necessary to move
Microsoft.VC++YYYYRedist-arch
toMicrosoft.VC++Redist/YYYY/Arch
before they become widely used as dependencies? (Although there have been 200+ manifest using this at this point)Proposed technical implementation details (optional)
No response
The text was updated successfully, but these errors were encountered: