Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to upgrade some programs #29785

Closed
Aerodymier opened this issue Oct 8, 2021 · 11 comments
Closed

It's impossible to upgrade some programs #29785

Aerodymier opened this issue Oct 8, 2021 · 11 comments
Labels
Help-Wanted This is a good candidate work item from the community.
Milestone

Comments

@Aerodymier
Copy link

Aerodymier commented Oct 8, 2021

Brief description of your issue

Some upgrades are impossible or way too hard. Take Python as an example. These 3 following commands:

winget upgrade "Python 3"
winget upgrade Python.Python.3
winget upgrade Python.Python.3 --version 3.10.150.0

always return 2 results and winget wants more input.

image

In this screenshot, I don't even know what the package below is. When I execute winget show {21b42743-c8f9-49d7-b8b6-b5855317c7ed}, it doesn't even show anything. Even if it did, upgrading this package would be possible because of the ID but upgrading normal Python is impossible because whenever I type its ID, both of them show up.

Steps to reproduce

  1. Execute one of these commands:

winget upgrade "Python 3"
winget upgrade Python.Python.3
winget upgrade Python.Python.3 --version 3.10.150.0

  1. You should see 2 inputs. Python was an example here, same thing happens with a lot of programs.

Expected behavior

I should be able to upgrade programs without that much effort. Commands should have a flag which will match exactly the ID provided.

Actual behavior

Some apps give 2 results and it's impossible to upgrade one of them.

Environment

Windows Package Manager version: v1.1.12702
Windows: Windows.Desktop version: v10.0.22000.194
Package: Microsoft.DesktopAppInstaller version: v1.16.12702.0

Any other software?
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Oct 8, 2021
@vedantmgoyal9
Copy link
Contributor

Probably we need to add ProductCode in all the manifests of Python.Python.3?

@kdpuvvadi
Copy link
Contributor

kdpuvvadi commented Oct 8, 2021

It's issue with msstore source from winget-cli. you can either use switch -e with complete package identifier(case sensitive)

winget install -e Python.Python.3

or you can remove msstore source with

winget source remove msstore

microsoft/winget-cli#1523
#29493

@Aerodymier
Copy link
Author

Is msstore source in use right now? Or is it still experimental?

@jedieaston
Copy link
Contributor

jedieaston commented Oct 8, 2021

It is in stable.

Running winget upgrade --source winget <arguments> should work.

@Aerodymier
Copy link
Author

In my opinion, source should be in the list which also shows IDs. So we can know what these different apps are from.

@denelon denelon added Help-Wanted This is a good candidate work item from the community. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Oct 11, 2021
@denelon
Copy link
Contributor

denelon commented Oct 12, 2021

@Aerodymier
Copy link
Author

This also happened with Microsoft.VC++2015-2019Redist-x64 today and I don't think that these have a msstore source.
image
It's not possible to update x64 version, I tried both its ID and its name.

@kdpuvvadi
Copy link
Contributor

It's working for me.

C:\Users\KD> winget install Microsoft.VC++2015-2019Redist-x64
Found Microsoft Visual C++ 2015-2019 Redistributable (x64) [Microsoft.VC++2015-2019Redist-x64] Version 14.29.30135.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/d3cbdace-2bb8-4dc5-a326-2c1c0f1ad5ae/9B9DD72C27AB1DB081DE56BB7B73BEE9A00F60D14ED8E6FDE45DAB3E619B5F04/VC_redist.x64.exe
  ██████████████████████████████  24.0 MB / 24.0 MB
Successfully verified installer hash
Starting package install...
Successfully installed

try with winget install -e --source winget Microsoft.VC++2015-2019Redist-x64

@Aerodymier
Copy link
Author

Aerodymier commented Oct 15, 2021

It's working for me.

C:\Users\KD> winget install Microsoft.VC++2015-2019Redist-x64
Found Microsoft Visual C++ 2015-2019 Redistributable (x64) [Microsoft.VC++2015-2019Redist-x64] Version 14.29.30135.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/d3cbdace-2bb8-4dc5-a326-2c1c0f1ad5ae/9B9DD72C27AB1DB081DE56BB7B73BEE9A00F60D14ED8E6FDE45DAB3E619B5F04/VC_redist.x64.exe
  ██████████████████████████████  24.0 MB / 24.0 MB
Successfully verified installer hash
Starting package install...
Successfully installed

try with winget install -e --source winget Microsoft.VC++2015-2019Redist-x64

It still warns me about multiple packages matching:
image

However this only happens if I try to upgrade. Installing works perfectly.

@Aerodymier
Copy link
Author

Looks like someone has added "Source" to this warning, thanks for it!

@DJviolin
Copy link

Confirming that upgrade doesn't work in Visual C++ packages:

$ winget upgrade --id Microsoft.VC++2015-2019Redist-x86 --source winget
$ winget upgrade --id Microsoft.VC++2015-2019Redist-x64 --source winget

What happens if I use install? I will have to 2x2 packages then? Isn't this an antipattern why winget exist on the first place?

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community.
Projects
None yet
Development

No branches or pull requests

6 participants