Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approving a PR as a moderator does nothing. #27041

Closed
jedieaston opened this issue Sep 6, 2021 · 6 comments
Closed

Approving a PR as a moderator does nothing. #27041

jedieaston opened this issue Sep 6, 2021 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@jedieaston
Copy link
Contributor

jedieaston commented Sep 6, 2021

Create issues related to the winget.exe client here

Brief description of your issue

Approving a PR as a moderator doesn't do anything.

Steps to reproduce

  1. Approve a PR using a GitHub account on the magic list (P.S.A. Moderation #15674).

Expected behavior

@msftbot adds the Moderator-Approved label, and assuming all other policies pass, the PR is merged into master.

Actual behavior

Nothing. No label, no friendly message from @msftbot, etc. No PRs have been merged for the last 50 hours or so :(. The Validation/Publishing Pipeline badges are still green, and the pipelines are still working. It's just the bot.

(I'm sorry @msftbot that I said those hurtful things about your ability to read and your favoritism of Apple Music over Spotify. If you come back it can be like old times :D).

@vedantmgoyal9
Copy link
Contributor

#26961 (comment)

@vedantmgoyal9
Copy link
Contributor

@denelon Please look into the issue with @msftbot.

@jedieaston
Copy link
Contributor Author

jedieaston commented Sep 7, 2021

image

*gulp*

@denelon
Copy link
Contributor

denelon commented Sep 7, 2021

Thanks for the heads-up! We're looking into it.

@denelon
Copy link
Contributor

denelon commented Sep 7, 2021

I just got a notification from the team about the "unscheduled down time" for the bot (@msftbot). The team is working on it. As soon as it's back up we'll work through the backlog.

@denelon denelon added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 7, 2021
@denelon
Copy link
Contributor

denelon commented Sep 7, 2021

It looks like the bot is back up and running again. Feel free to @mention me if there are some that need the 'Moderator Approved" label added.

@denelon denelon closed this as completed Sep 7, 2021
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants