Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request]: Questions around onboarding a new package : Microsoft Authentication CLI #183643

Open
1 task done
keyuxuan opened this issue Oct 16, 2024 · 4 comments
Open
1 task done
Labels
Package-Request This is a request for a package (new or updated version) zip-binary Depends on library files that aren't available via symlink

Comments

@keyuxuan
Copy link

keyuxuan commented Oct 16, 2024

How can we help?

I would like help so I can submit the manifest.

Please read and ensure the following

  • The installer meets the above requirements

Please provide the following information

Download Page Url: https://github.com/AzureAD/microsoft-authentication-cli/releases/tag/0.8.6
Publisher: Microsoft
Package Name: microsoft-authentication-cli
Description: AzureAuth is a CLI wrapper for performing AAD Authentication. It makes use of MSAL for authentication and caching.
Package Version: 0.8.6
Installer Url: https://github.com/AzureAD/microsoft-authentication-cli/releases/download/0.8.6/azureauth-0.8.6-win10-x64.zip

i installed winget-cli version v1.9.2507 on my machine and I have followed this page to create the manifests using wingetcreate new command. Now i have three manifest files and the validation and installation are both successful.

Version manifest preview:
# Created using wingetcreate 1.6.5.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json

PackageIdentifier: Microsoft.microsoft-authentication-cli
PackageVersion: 0.8.6
DefaultLocale: en-US
ManifestType: version
ManifestVersion: 1.6.0
Installer manifest preview:
# Created using wingetcreate 1.6.5.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json

PackageIdentifier: Microsoft.microsoft-authentication-cli
PackageVersion: 0.8.6
InstallerType: zip
NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: azureauth.exe
Installers:
- InstallerUrl: https://github.com/AzureAD/microsoft-authentication-cli/releases/download/0.8.6/azureauth-0.8.6-win10-x64.zip
  Architecture: x64
  InstallerSha256: 6E1AB3F38B2A3BA5096FE818B27B1C850DF43D947DF80AA5935425BD978CA54E
ManifestType: installer
ManifestVersion: 1.6.0
Default locale manifest preview:
# Created using wingetcreate 1.6.5.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json

PackageIdentifier: Microsoft.microsoft-authentication-cli
PackageVersion: 0.8.6
PackageLocale: en-US
Publisher: Microsoft
PackageName: microsoft-authentication-cli
License: MIT License
ShortDescription: AzureAuth is a CLI wrapper for performing AAD Authentication. It makes use of MSAL for authentication and caching.
ManifestType: defaultLocale
ManifestVersion: 1.6.0

However, when i tested the command azureauh --version, i ran into this issue The application to execute does not exist: 'C:\Users\keyuxuan\AppData\Local\Microsoft\WinGet\Links\azureauth.dll'..

Does anyone know why this happens even tho installation was successful and how to fix this?

Image

Image

@keyuxuan keyuxuan added Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version) labels Oct 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Oct 16, 2024
@aisgbnok
Copy link
Contributor

This issue appears related to the recently closed microsoft/winget-cli#2711.

Unfortunately, you will have to upgrade your manifests to ManifestVersion: 1.9.0 and add the ArchiveBinariesDependOnPath field. However, manifest version 1.9.0 is not generally available / public and documentation is lacking for now. I would expect it to be enabled in this repo, winget CLI, and wingetcreate within the next two months. Though someone with more authority than me is free to correct that estimate.

@Dragon1573
Copy link
Contributor

Note

Policy: Blocking-Issue Manifest validation is blocked by a known issue. zip-binary Depends on library files that aren't available via symlink

@stephengillie stephengillie added Blocking-Issue Manifest validation is blocked by a known issue. zip-binary Depends on library files that aren't available via symlink and removed Help-Wanted This is a good candidate work item from the community. Needs-Triage This work item needs to be triaged by a member of the core team. labels Oct 18, 2024
@denelon
Copy link
Contributor

denelon commented Dec 3, 2024

@keyuxuan we've just recently added support for portable applications with a requirement to use dependencies in the executable path. If you want to update the manifest and give it a shot, we'd love to be able to confirm it's working correctly.

@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2024

[Policy] Unblocked; Will require ManifestVersion: 1.9.0 with ArchiveBinariesDependOnPath: true

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Blocking-Issue Manifest validation is blocked by a known issue. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package-Request This is a request for a package (new or updated version) zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

No branches or pull requests

6 participants