Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wingetcreate update if latest InstallerUrl #72

Closed
OfficialEsco opened this issue Jun 9, 2021 · 4 comments · Fixed by #447
Closed

wingetcreate update if latest InstallerUrl #72

OfficialEsco opened this issue Jun 9, 2021 · 4 comments · Fixed by #447
Labels
In-PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone

Comments

@OfficialEsco
Copy link

Description of the new feature/enhancement

wingetcreate update should delete the old version folder if it uses the same InstallerUrl and count as Update and Rename so we or the bot don't have to clean up the folder afterwards.

@OfficialEsco OfficialEsco added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 9, 2021
@ghost ghost added the Needs-Triage label Jun 9, 2021
@denelon denelon added this to the v.Next - `winget create` milestone Jun 9, 2021
@denelon
Copy link
Contributor

denelon commented Jun 10, 2021

@OfficialEsco do you have an example PR showing what this looks like? I did a quick search and didn't find an example.

@OfficialEsco
Copy link
Author

OfficialEsco commented Jun 10, 2021

That's because you're looking too far https://github.com/microsoft/winget-pkgs/pull/16874/files
This is how it SHOULD look, if you move a few lines it will count as a new file. Wingetbot/WinGetcreate is therefore incompetable with each other.

Sometimes this happens for some reason https://github.com/microsoft/winget-pkgs/pull/16993/files

@palenshus
Copy link
Contributor

The latter case is probably due to line endings changing. Anyway, I'm wondering if in cases like this the version shouldn't just be changed to "latest" in the manifest, and that way the directory doesn't change from update to update?

@OfficialEsco
Copy link
Author

Well wingetbot only updates the hash, I can do a lot bigger changes without the whole file getting recreated...

We have stopped using Latest PackageVersion as it causes issues with winget upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants