-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items at root level are not modified #211
Comments
Sorry for lack of repro steps; I figured that having an issue was most important, even if I wasn't sure how to reproduce |
The PR introduces the behavior where the fields at the root level will be moved and overwritten at the installer level before the update begins. At the end of the update, the values to be moved back to the root level if they are common between all installers. So now, you won't have a case where the ProductCode at the root level will be different from an installer level ProductCode |
Brief description of your issue
When a product code exists at the root level and a package is updated using wingetcreate, the product code from the root level is not considered when updating the product code at the installer level
Edit: This applies to all other fields too
Steps to reproduce
Unsure how to reproduce; Noticed in https://github.com/microsoft/winget-pkgs/pull/37334/files#diff-b05d41986a400b8d3fc1c2f419d8e8f48290cba8ae0ce8ac5db177b44c415eb9
Expected behavior
The product code at the root level will be either updated or removed
Actual behavior
There are two different product codes in the manifest
Environment
¯\_(ツ)_/¯
The text was updated successfully, but these errors were encountered: