Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denied packages should be hidden from winget upgrade list #4299

Open
mdanish-kh opened this issue Mar 23, 2024 · 4 comments
Open

Denied packages should be hidden from winget upgrade list #4299

mdanish-kh opened this issue Mar 23, 2024 · 4 comments
Labels
Command-Upgrade Issue related to WinGet Upgrade Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Mar 23, 2024

Description of the new feature / enhancement

Packages that have UpgradeBehavior: deny set should be hidden from winget upgrade / winget list --upgrade-available list. We can have an argument --include-denied to show these packages. The current output for pinned, unknown and explicit targeted packages can be extended to show number of denied packages.

Current sample output

The following packages have an upgrade available, but require explicit targeting for upgrade:
Name                         Id              Version      Available            Source
-------------------------------------------------------------------------------------
Discord                      Discord.Discord 1.0.9016     1.0.9035             winget
Microsoft Teams              Microsoft.Teams 1.6.00.29964 23320.3027.2591.1505 winget
Teams Machine-Wide Installer Microsoft.Teams 1.5.0.8070   23320.3027.2591.1505 winget
1 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
21 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

New sample output line

1 package(s) do not support upgrades through winget. Use --include-denied to see more results.

Proposed technical implementation details

No response

@mdanish-kh mdanish-kh added the Issue-Feature This is a feature request for the Windows Package Manager client. label Mar 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Mar 23, 2024
@mdanish-kh
Copy link
Contributor Author

[Policy] Command-Upgrade

@microsoft-github-policy-service microsoft-github-policy-service bot added Command-Upgrade Issue related to WinGet Upgrade and removed Needs-Triage Issue need to be triaged labels Mar 23, 2024
@CanePlayz
Copy link

I second this

@treysis
Copy link

treysis commented Sep 7, 2024

1 package(s) do not support upgrades through winget. Use --include-denied to see more results.

This is not strictly true, though. Updates have just been disabled in the manifest. In the case of Discord for example, the update itself works fine, the installer just doesn't update the DisplayVersion, and thus winget will not know that the app has been updated.

I suggest an output like this:

1 package(s) have been disabled for updates through winget. Use --include-denied to see more results.

@CanePlayz
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-Upgrade Issue related to WinGet Upgrade Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants