Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip installers not getting nested installer type defaults #2392

Closed
JohnMcPMS opened this issue Jul 28, 2022 · 1 comment · Fixed by #2413
Closed

Zip installers not getting nested installer type defaults #2392

JohnMcPMS opened this issue Jul 28, 2022 · 1 comment · Fixed by #2413
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone
v1.4-Client

Comments

@JohnMcPMS
Copy link
Member

Brief description of your issue

Installers within zip files are not getting the default values for their nested installer, such as switches and error codes.

Steps to reproduce

Use zip.

Expected behavior

Works as if not zipped.

Actual behavior

Has no command line arguments passed.

Environment

CI/CD
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 28, 2022
@JohnMcPMS JohnMcPMS added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jul 28, 2022
@JohnMcPMS
Copy link
Member Author

When fixed, re-enable the E2E test InstallZipWithMsi.

@denelon denelon added this to the v1.4-Client milestone Jul 28, 2022
@ryfu-msft ryfu-msft mentioned this issue Aug 3, 2022
Merged
@ghost ghost added the In-PR Issue related to a PR label Aug 3, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
v1.4-Client
Development

Successfully merging a pull request may close this issue.

Ensure default values are passed to nested installers within zip ryfu-msft/winget-cli
3 participants
@JohnMcPMS @denelon @ryfu-msft