Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget import with app store apps always returns msstore source not installed #1556

Closed
VArterJr opened this issue Oct 7, 2021 · 13 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. msstore Issue related to "msstore" REST source Resolution-Duplicate Issue is a duplicate
Milestone

Comments

@VArterJr
Copy link
Member

VArterJr commented Oct 7, 2021

Brief description of your issue

With the new GA Windows 11 Enterprise ISO (22000.194) running the below command does not work with the json file that worked on Win 11 beta and Win 10 with latest winget. I even tried using the leading-edge version (1.1.12701) and adding msstore experimental settings back to the winget settings file. It always generates the message: "Source required for import is not installed: msstore"

winget import -i mylifstofapps.json

I've confirmed with winget source list that it is enabled. I can also force a manual of items one by one with winget commands like below and they work. It is only the import that just doesn't seem to work on any machine with the GA of Win 11.

winget source list

Name Argument

msstore https://storeedgefd.dsx.mp.microsoft.com/v9.0
winget https://winget.azureedge.net/cache

Steps to reproduce

Be on Win 11 Enterprise 22000.194 and either the GA shipping version of winget with Win 11 or the latest 1.1.12701. Import a json file that has any number of msstore source items to install. Those same items install fine with winget install.

Expected behavior

Since it worked on Win 11 beta and Win 10 with the latest winget, I would expect it to work here too. I've scoured what documentation there is and don't see any changes in format of the import file that would make a difference.

Actual behavior

The import with fail with Source required for import is not installed: msstore unless you remove the section for that source in your json file to import.

Environment

Windows Package Manager v1.1.12701
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.194
Package: Microsoft.DesktopAppInstaller v1.16.12701.0

Any other software? Microsoft Office (current 365 version)
@ghost ghost added the Needs-Triage Issue need to be triaged label Oct 7, 2021
@jedieaston
Copy link
Contributor

jedieaston commented Oct 7, 2021

Can you post your exported json?

Edit: something else interesting I found while investigating this is that winget export doesn't export apps installed from the Microsoft Store since it can't find them.

@denelon
Copy link
Contributor

denelon commented Oct 7, 2021

We have been working with the store source to improve matching. We were seeing several bad matches due to the search results. That's the next improvement we're working on. We removed the matching in "list" and subsequently "export" (export depends on list for matching) from the store source. As soon as the matching is improved (next patch expected next week) we will test again and add it back if it's working correctly.

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. msstore Issue related to "msstore" REST source and removed Needs-Triage Issue need to be triaged labels Oct 7, 2021
@denelon denelon added this to the v1.2-Client milestone Oct 7, 2021
@denelon
Copy link
Contributor

denelon commented Oct 7, 2021

The import command should work, but it's likely you would need to use the "Id" value from the current search results to get import to install the correct package from the msstore source.

@JohnMcPMS
Copy link
Member

The import command should work, but it's likely you would need to use the "Id" value from the current search results to get import to install the correct package from the msstore source.

Yes, please post your import file. It is most likely behind the scenes changes between experimental and release that have caused that one string to be invalid now.

Edit: something else interesting I found while investigating this is that winget export doesn't export apps installed from the Microsoft Store since it can't find them.

Spoilers; I'm doing work right now that will at least enable this to work for things installed from the Store via winget (and some from the Store app itself; its complicated).

@VArterJr
Copy link
Member Author

VArterJr commented Oct 8, 2021

Can you post your exported json?

Edit: something else interesting I found while investigating this is that winget export doesn't export apps installed from the Microsoft Store since it can't find them.

Correct. I apologize for missing that. Export does not include it msstore any longer.

@denelon
Copy link
Contributor

denelon commented Oct 8, 2021

@VArterJr
Copy link
Member Author

VArterJr commented Oct 8, 2021

Here is an example (smaller than my real one). Please note I've tried this URL for the Argument in Source included in the json file as well as what winget source list shows which is https://storeedgefd.dsx.mp.microsoft.com/v9.0. Neither works
teststoreapps.json.txt

(Note: I had to change file name to .txt to upload it here.)

@JohnMcPMS
Copy link
Member

Replace the SourceDetails with this:

			"SourceDetails": {
				"Argument": "https://storeedgefd.dsx.mp.microsoft.com/v9.0",
				"Identifier": "StoreEdgeFD",
				"Name": "msstore",
				"Type": "Microsoft.Rest"
			}

@VArterJr
Copy link
Member Author

VArterJr commented Oct 11, 2021

Replace the SourceDetails with this:

			"SourceDetails": {
				"Argument": "https://storeedgefd.dsx.mp.microsoft.com/v9.0",
				"Identifier": "StoreEdgeFD",
				"Name": "msstore",
				"Type": "Microsoft.Rest"
			}

That worked to get it going past the original error. Thanks for the help.

As a side questions: Is this source config documented somewhere? I searched for day and days and could never find a good template, example, or note on what that should be. And since the export isn't working for app store apps, I couldn't see this needed change.

@denelon
Copy link
Contributor

denelon commented Oct 11, 2021

@VArterJr we temporarily disabled the list and subsequently export due to several weak matching results. We have improvements coming to the "msstore" source to alleviate the issue so we can re-enable matching with the source.

@VArterJr
Copy link
Member Author

OK. This ticket can be closed. Do you want me to close it with comment or will someone from the team?

@denelon
Copy link
Contributor

denelon commented Oct 11, 2021

Duplicate of #1562

@denelon denelon marked this as a duplicate of #1562 Oct 11, 2021
@ghost
Copy link

ghost commented Oct 11, 2021

@VArterJr we've identified this Issue as a duplicate of another one that already exists. This specific instance is being closed in favor of tracking the concern over on the referenced Issue. Thanks for your report! Be sure to add your 👍 to the other issue to help raise the priority.

@ghost ghost closed this as completed Oct 11, 2021
@ghost ghost added the Resolution-Duplicate Issue is a duplicate label Oct 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. msstore Issue related to "msstore" REST source Resolution-Duplicate Issue is a duplicate
Projects
Archived in project
Development

No branches or pull requests

4 participants