Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markets to manifest #1241

Closed
denelon opened this issue Jul 1, 2021 · 2 comments · Fixed by #1806
Closed

Add Markets to manifest #1241

denelon opened this issue Jul 1, 2021 · 2 comments · Fixed by #1806
Assignees
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Jul 1, 2021

Description of the new feature/enhancement

The new store source we are working on requires information regarding the market a given user is in. We need to extend the manifest to we can support behaviors related to markets.

This would be optional, and a manifest could specify either an allow list, or a deny list.

Proposed technical implementation details (optional)

Markets will have an "Allow" list and a "Exclusion" list.

If the client receives both lists and any individual market is in both lists the client will not proceed.
 And the client will inform the user the manifest is invalid due to markets.

If the client receives either (but only one list) the client will only evaluate based on the list it received
If we receive an allow list:
 If the client is in the market included in the allow list, then the install will proceed.
 If the client is not in the market included in the allow list then the install will not proceed.
  And the client will inform the user that the package is not allowed in their market.

If we receive an Exclusion list:
 If the client is in the market included in the exclusion list, then the install will not proceed.
  And the client will inform the user that the package is not allowed in their market.
 If the client is not in the market included in the exclusion list, then the install will proceed.

If the client receives both an allow list and an exclusion list the client will behave as though it only received an allow list.

Installers:
  - InstallerType: exe
    InstallerArchitecture: x64
    InstallerSHA256: 12341234123412341234123412341234123412341234
    InstallerURL: https://www.contoso.com/awesomeapp/1.0.0/awesomeapp.x64.exe
    Markets:
      AllowedMarkets:
       - DE
      ExcludedMarkets:
       - US
@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. Area-Manifest This may require a change to the manifest labels Jul 1, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 1, 2021
@denelon denelon added this to the v.Next - Windows Package Manager milestone Jul 1, 2021
@denelon denelon removed the Needs-Triage Issue need to be triaged label Jul 1, 2021
@denelon denelon added this to WinGet Oct 1, 2021
@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

"Markets": {
"description": "The installer markets",
"type": [ "object", "null" ],
"oneOf": [
{
"properties": {
"AllowedMarkets": {
"$ref": "#/definitions/MarketArray"
}
},
"required": [ "AllowedMarkets" ]
},
{
"properties": {
"ExcludedMarkets": {
"$ref": "#/definitions/MarketArray"
}
},
"required": [ "ExcludedMarkets" ]
}
]
},

#1427

@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

This will be completed when winget-pkgs supports the 1.1 schema.

@ghost ghost added the In-PR Issue related to a PR label Dec 15, 2021
@denelon denelon modified the milestones: v.Next-Client, v1.3-Client Jan 8, 2022
Repository owner moved this from In Progress to Done in WinGet Jan 24, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants