Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source option does not work on list #1019

Closed
AdilHindistan opened this issue May 29, 2021 · 7 comments
Closed

source option does not work on list #1019

AdilHindistan opened this issue May 29, 2021 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@AdilHindistan
Copy link

AdilHindistan commented May 29, 2021

Brief description of your issue

When I use --source or -s to filter installed packages by source, result does not get filtered, I get the full list of installed apps instead.

Steps to reproduce

  1. winget list --source winget

  2. winget list --name visual --source winget

PS C:\Users\adil> winget list --name visual --source winget
Name                                                               Id                                     Version        Available Source
-----------------------------------------------------------------------------------------------------------------------------------------
Microsoft Visual C++ 2010  x64 Redistributable - 10.0.40219        {1D8E6291-B0D5-35EC-8441-6616F567A0F7} 10.0.40219
Microsoft Visual C++ 2008 Redistributable - x64 9.0.30729.6161     {5FCE6D76-F5DC-37AB-B2B8-22AB8CEDB1D4} 9.0.30729.6161
Microsoft Visual C++ 2008 Redistributable - x64 9.0.30729.17       {8220EEFE-38CD-377E-8595-13398D740ACE} 9.0.30729
Visual Studio Code                                                 Microsoft.VisualStudioCode             1.47.3         1.56.2    winget
... (shortened)

Expected behavior

  1. Get the list of all installed apps where source is winget
  2. Get the list of packages that have 'visual' in name and source is winget

Actual behavior

  1. I get the list of all apps regardless of the source. I.e. source is ignored
  2. I get the list of all apps with 'visual' in the name regardless of the source. Source is ignored.

Environment

> winget --info
Windows Package Manager v1.0.11451
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19042.985
Package: Microsoft.DesktopAppInstaller v1.11.11451.0

@ghost ghost added the Needs-Triage Issue need to be triaged label May 29, 2021
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jun 1, 2021
@denelon
Copy link
Contributor

denelon commented Jun 1, 2021

@AdilHindistan are you looking for packages that have an upgrade available from a given source, or are you looking for any packages installed with a corresponding manifest is a given source?

winget upgrade -s <source> would provide the list of packages with upgrades available from a given source.

@denelon denelon added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 1, 2021
@AdilHindistan
Copy link
Author

@denelon That command is quite useful, thank you. In my case, I simply wanted to see what was installed by winget vs other means. Maybe the "source" is a bit misleading. I am pretty sure I did not use winget to install some of the packages listed. I guess it just means winget has a version for the installed package?
I thought I can use -s to filter installed packages list by source but I guess not?

@ghost ghost added Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Jun 3, 2021
@denelon
Copy link
Contributor

denelon commented Jun 9, 2021

@AdilHindistan you are correct. The source column in the list output just shows a package from an available source that "should" be an upgrade. We don't record what was installed by the Windows Package Manager vs. another install method yet.

@denelon denelon removed the Needs-Attention Issue needs attention from Microsoft label Jun 9, 2021
@denelon
Copy link
Contributor

denelon commented Jun 9, 2021

I'm going to close this bug since it appears the client is behaving as expected.

@denelon denelon closed this as completed Jun 9, 2021
@KaranKad
Copy link

I think winget list -s winget should show what apps are installed on my system, available from given source and should filter out apps that have no/different source. Currently winget list -s winget is similar to winget list command, just outputting list of all the applications installed on system instead just showing apps from given source. This command will be helpful to know exactly which installed apps winget can recognize/know if available in winget-pkgs or any custom source. Output could be similar to winget export command where apps with unknown sources are removed from the list.

@denelon
Copy link
Contributor

denelon commented Jul 20, 2021

@KaranKad #1155 looks like what you're suggesting.

@KaranKad
Copy link

Yeah that's exactly it 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants