Updated Readme file to include link to #88 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue thread microsoft#88 offers some great points on what makes a good pull request. However, it is buried under a lot of different issues and can be difficult to reach, especially for new contributors who might not know this discussion exists. As such, I felt it necessary to add a direct link to the thread under the "Contributing" section of the readme file.
|
Thanks @NazmusLabs. I have a backlog of great comments to review. |
|
Isn't it be better if you place the URLs in separate section? Like following example: After placing the URL in separate section, this will be: |
|
@Biswa96 sure. I was debating this myself. Decided to not have a redundant link on my commit, but I'm equally favorable to the other approach you noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue thread #88 offers some great points on what makes a good pull request. However, it is buried under a lot of different issues and can be difficult to reach, especially for new contributors who might not know this discussion exists. As such, I felt it necessary to add a direct link to the thread under the "Contributing" section of the readme file.