Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build should test x86, x64, nightly, and stable #522

Closed
kennykerr opened this issue Feb 5, 2021 · 3 comments · Fixed by #624
Closed

The build should test x86, x64, nightly, and stable #522

kennykerr opened this issue Feb 5, 2021 · 3 comments · Fixed by #624
Labels
enhancement New feature or request

Comments

@kennykerr
Copy link
Collaborator

Currently it only builds x64 and there may be x86 issues that go undetected. For example, these functions are only available for x64 builds:

#[link(name = "user32")]
extern "system" {
fn SetWindowLongPtrA(window: HWND, index: i32, value: isize) -> isize;
fn GetWindowLongPtrA(window: HWND, index: i32) -> isize;
}

We need to use GetWindowLongA and SetWindowLongA for x86 builds.

@kennykerr kennykerr added the enhancement New feature or request label Feb 5, 2021
@kennykerr
Copy link
Collaborator Author

The build should perhaps also run nightly and stable, not just stable.

@kennykerr kennykerr changed the title The build should test both x86 and x64 targets The build should test x86, x64, nightly, and stable Feb 19, 2021
@kennykerr kennykerr removed the library label Mar 4, 2021
@kennykerr
Copy link
Collaborator Author

Blocked on rust-lang/rust#82991

@rylev
Copy link
Contributor

rylev commented Mar 15, 2021

I've not yet been able to find the root cause of the issue in rustc, but it seems to be an issue from the renaming of the crate in the Cargo.toml file. If you change windows_gen Cargo.toml file to specify windows_gen_macros like so windows_gen_macros = { path = "macros", version = "0.4.0" } and rename all instances of macros to windows_gen_macros inside the windows_gen crate, the code compiles with cargo +nightly build --target=i686-pc-windows-msvc.

Of course, the issue in rustc should be fixed so it's up to you whether you want to implement the workaround or wait until the compiler is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants