implement/interface macro docs are outdated

[beanbean97]

Summary

ver: windows-rs 0.58

use windows::core::*;

#[interface("094d70d6-5202-44b8-abb8-43860da5aca2")]
unsafe trait IValue: IUnknown {
    fn GetValue(&self, value: *mut i32) -> HRESULT;
}

#[implement(IValue)]
struct Value(i32);

impl IValue_Impl for Value {
    unsafe fn GetValue(&self, value: *mut i32) -> HRESULT {
        *value = self.0;
        HRESULT(0)
    }
}

get compile error=>

error[E0277]: the trait bound `Value_Impl: IValue_Impl` is not satisfied
 --> src\test.rs:8:1
  |
8 | #[implement(IValue)]
  | ^^^^^^^^^^^^^^^^^^^^ the trait `IValue_Impl` is not implemented for `Value_Impl`
  |
  = help: the trait `IValue_Impl` is implemented for `arc_stream::Value`
note: required by a bound in `IValue_Vtbl::new`
 --> src\test.rs:4:14
  |
3 | #[interface("094d70d6-5202-44b8-abb8-43860da5aca2")]
  | ---------------------------------------------------- required by a bound in this associated function
4 | unsafe trait IValue: IUnknown {
  |              ^^^^^^ required by this bound in `IValue_Vtbl::new`
  = note: this error originates in the attribute macro `implement` (in Nightly builds, run with -Z macro-backtrace for more info)

Crate manifest

No response

Crate code

No response

[beanbean97]

ver:0.57 can compile,seem that some change in v0.58 lead this error

[kennykerr]

This changed here: #3065

Looks like the doc comments are not being compiled. Will have to look into that.

[kennykerr]

Here's a complete example that should work:

#![allow(non_snake_case)]

use windows_core::*;

#[interface("094d70d6-5202-44b8-abb8-43860da5aca2")]
unsafe trait IValue: IUnknown {
    fn GetValue(&self, value: *mut i32) -> HRESULT;
}

#[implement(IValue)]
struct Value(i32);

impl IValue_Impl for Value_Impl {
    unsafe fn GetValue(&self, value: *mut i32) -> HRESULT {
        *value = self.0;
        HRESULT(0)
    }
}

fn main() -> Result<()> {
    let object: IValue = Value(123).into();

    let mut value = 0;
    unsafe { object.GetValue(&mut value).ok()? };
    println!("{value}");

    Ok(())
}

[beanbean97]

thanks,that work