Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuplicateHandle should take a *mut HANDLE argument for lp_target_handle #252

Closed
zaddach opened this issue Feb 17, 2021 · 1 comment
Closed

DuplicateHandle should take a *mut HANDLE argument for lp_target_handle #252

zaddach opened this issue Feb 17, 2021 · 1 comment
Labels
broken api An API is inaccurate and could lead to runtime failure

Comments

@zaddach
Copy link

zaddach commented Feb 17, 2021

The fourth argument of DuplicateHandle is currently a *mut isize, but should be a *mut HANDLE.

https://microsoft.github.io/windows-docs-rs/doc/bindings/windows/win32/windows_programming/fn.DuplicateHandle.html
@kennykerr
Copy link
Contributor

In the original metadata, the lpTargetHandle parameter is IntPtr* when it should be HANDLE*.

@kennykerr kennykerr added the broken api An API is inaccurate and could lead to runtime failure label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken api An API is inaccurate and could lead to runtime failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaddach @kennykerr