Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native type defs changed from IntPtr fields to void* #1936

Closed
AArnott opened this issue Jun 24, 2024 · 1 comment
Closed

Native type defs changed from IntPtr fields to void* #1936

AArnott opened this issue Jun 24, 2024 · 1 comment

Comments

@AArnott
Copy link
Member

AArnott commented Jun 24, 2024

Was the change of handles from IntPtr to void* intentional in the v61 release of the metadata? It broke cswin32, and while I can make a change to accommodate this change, I wonder what value this change brought to the metadata or projections to confirm it will remain before I adjust CsWin32.

 [RAIIFree("CloseHandle")]
 [InvalidHandleValue(-1L)]
 [InvalidHandleValue(0L)]
 [NativeTypedef]
 public struct HANDLE
 {
-	public IntPtr Value;
+       public unsafe void* Value;
 }
@robmikh
Copy link
Member

robmikh commented Jun 25, 2024

Related: #1924

@AArnott AArnott closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants