Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT_MANIFEST is u32 while RT_ICON is PCWSTR #1883

Closed
xnuk opened this issue Apr 12, 2024 · 1 comment
Closed

RT_MANIFEST is u32 while RT_ICON is PCWSTR #1883

xnuk opened this issue Apr 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@xnuk
Copy link

xnuk commented Apr 12, 2024

Summary

In windows::Win32::UI::WindowsAndMessaging, only RT_MANIFEST is u32 while other RT_* constants are all PCWSTR.

pub const RT_ACCELERATOR: ::windows_core::PCWSTR = ::windows_core::PCWSTR(9u16 as _);
pub const RT_ANICURSOR: ::windows_core::PCWSTR = ::windows_core::PCWSTR(21u16 as _);
pub const RT_ANIICON: ::windows_core::PCWSTR = ::windows_core::PCWSTR(22u16 as _);
pub const RT_BITMAP: ::windows_core::PCWSTR = ::windows_core::PCWSTR(2u16 as _);
pub const RT_CURSOR: ::windows_core::PCWSTR = ::windows_core::PCWSTR(1u16 as _);
pub const RT_DIALOG: ::windows_core::PCWSTR = ::windows_core::PCWSTR(5u16 as _);
pub const RT_DLGINCLUDE: ::windows_core::PCWSTR = ::windows_core::PCWSTR(17u16 as _);
pub const RT_FONT: ::windows_core::PCWSTR = ::windows_core::PCWSTR(8u16 as _);
pub const RT_FONTDIR: ::windows_core::PCWSTR = ::windows_core::PCWSTR(7u16 as _);
pub const RT_HTML: ::windows_core::PCWSTR = ::windows_core::PCWSTR(23u16 as _);
pub const RT_ICON: ::windows_core::PCWSTR = ::windows_core::PCWSTR(3u16 as _);
pub const RT_MANIFEST: u32 = 24u32;
pub const RT_MENU: ::windows_core::PCWSTR = ::windows_core::PCWSTR(4u16 as _);
pub const RT_MESSAGETABLE: ::windows_core::PCWSTR = ::windows_core::PCWSTR(11u16 as _);
pub const RT_PLUGPLAY: ::windows_core::PCWSTR = ::windows_core::PCWSTR(19u16 as _);
pub const RT_VERSION: ::windows_core::PCWSTR = ::windows_core::PCWSTR(16u16 as _);
pub const RT_VXD: ::windows_core::PCWSTR = ::windows_core::PCWSTR(20u16 as _);

Crate manifest

[build-dependencies.windows]
version = '0.54.0'
features = ['Win32_UI_WindowsAndMessaging']

Crate code

No response

@xnuk xnuk added the bug Something isn't working label Apr 12, 2024
@kennykerr
Copy link
Contributor

This comes from metadata. Will transfer to the Win32 metadata repo for consideration.

@kennykerr kennykerr transferred this issue from microsoft/windows-rs Apr 12, 2024
@mikebattista mikebattista self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants