Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain constants appear to be missing (e.g. WINSTA_ALL_ACCESS) #1835

Closed
starrify opened this issue Jan 27, 2024 · 1 comment
Closed

Certain constants appear to be missing (e.g. WINSTA_ALL_ACCESS) #1835

starrify opened this issue Jan 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@starrify
Copy link

Summary

One example is WINSTA_ALL_ACCESS (MSDN link) that is defined in WinUser.h:

#define WINSTA_ALL_ACCESS           (WINSTA_ENUMDESKTOPS  | WINSTA_READATTRIBUTES  | WINSTA_ACCESSCLIPBOARD | \
                                     WINSTA_CREATEDESKTOP | WINSTA_WRITEATTRIBUTES | WINSTA_ACCESSGLOBALATOMS | \
                                     WINSTA_EXITWINDOWS   | WINSTA_ENUMERATE       | WINSTA_READSCREEN)

The other WINSTA_* constants are included here:
https://github.com/microsoft/windows-rs/blob/a2fbd102010a20ac35ff0d950e44f193cd032751/crates/libs/sys/src/Windows/Win32/UI/WindowsAndMessaging/mod.rs#L2345-L2353

Another random example of missing constants is WVR_REDRAW (defined as WVR_HREDRAW | WVR_VREDRAW), where similarly other WVR_* constants do exist.

However not all constants of the same shape are missing. E.g. WS_OVERLAPPEDWINDOW is defined in the similar way from WinUser.h and is indeed included here.

Crate manifest

No response

Crate code

No response

@starrify starrify added the bug Something isn't working label Jan 27, 2024
@riverar
Copy link
Collaborator

riverar commented Jan 27, 2024

Thanks, will move this to upstream metadata repository where the bug lies.

@riverar riverar transferred this issue from microsoft/windows-rs Jan 27, 2024
@mikebattista mikebattista self-assigned this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants