Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRGN_UserUnmarshal has invalid fixed array size parameter #1014

Closed
kennykerr opened this issue Jul 27, 2022 · 0 comments · Fixed by #1235
Closed

HRGN_UserUnmarshal has invalid fixed array size parameter #1014

kennykerr opened this issue Jul 27, 2022 · 0 comments · Fixed by #1235
Assignees
@sotteson1
Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working rust Critical for Rust adoption

Comments

@kennykerr
Copy link
Contributor

The expected array is apparently zero bytes long. I suspect it is because the metadata parser is incorrectly parsing the SAL annotation:

unsigned char * __RPC_USER  HRGN_UserUnmarshal(__RPC__in unsigned long *, __RPC__in_xcount(0) unsigned char *, __RPC__out HRGN * );
@kennykerr kennykerr mentioned this issue Jul 27, 2022
Merged
@mikebattista mikebattista added bug Something isn't working broken api An API is inaccurate and could lead to runtime failure labels Aug 1, 2022
@kennykerr kennykerr added the rust Critical for Rust adoption label Sep 2, 2022
@sotteson1 sotteson1 mentioned this issue Sep 9, 2022
Merged
kennykerr added a commit to microsoft/windows-rs that referenced this issue Sep 12, 2022
@kennykerr
https://github.com/microsoft/win32metadata/issues/1014
7b5df6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sotteson1 sotteson1

Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working rust Critical for Rust adoption
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SAL bug for CountConst=0 microsoft/win32metadata
3 participants
@kennykerr @mikebattista @sotteson1