-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extensions to access all terminals #47678
Conversation
* An [event](#Event) which fires when a terminal has been created, either through the | ||
* [createTerminal](#window.createTerminal) API or commands. | ||
*/ | ||
export const onDidOpenTerminal: Event<Terminal>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think about a TerminalOpenEvent
so that you a chance of adding more stuff in the future..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, should open come with close?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onDidCloseTerminal
already exists as an Event<Terminal>
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed that 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different file 😉
New proposed APIs:
Changes to existing behavior:
Terminal.name
andTerminal.processId
can be accessed on a disposed terminalSee usage example at https://github.com/Microsoft/vscode-extension-samples/blob/master/terminal-sample/src/extension.ts
Fixes #13267
Part of #46192
/cc @dbaeumer @weinand @IlyaBiryukov @alpaix