Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sash double clicks #4702

Merged
merged 8 commits into from
Apr 15, 2016
Merged

Sash double clicks #4702

merged 8 commits into from
Apr 15, 2016

Commits on Apr 14, 2016

  1. Support double click on sashes 

    We had to implement a slight change in the sash drag "hack", by removing the
full cover transparent overlay (that was preventing clicks events from being
fired) and replacing it by a CSS `cursor` rule on the document.body.

The ideal solution for a clean dragging events implementation would be to use
the `Element.setCapture` API that is unfortunately not available in Chrome.
    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    cd0ad5c View commit details
    Browse the repository at this point in the history

  2. Center the split editor frontier by double-clicking on it

    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    451730a View commit details
    Browse the repository at this point in the history

  3. Implement sash reset on diff editors

    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    78acad8 View commit details
    Browse the repository at this point in the history

  4. Reset the bottom panel size by double-clicking on it

    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    c6a47a9 View commit details
    Browse the repository at this point in the history

  5. Fix a bug with DOM measurement 

    The calculus was plain wrong as showed in winjs/winjs#1621
This was probably unotified since this utility function wasn't used in the code base.
    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    868e988 View commit details
    Browse the repository at this point in the history

  6. Implement sidebar sash optimal resizing 

    Fixes microsoft#4660
    @mquandalle
    mquandalle committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    af43674 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2016

  1. Abstract getLargestChildWidth into a DOM method 

    This commit also moves the `getOptimalWidth` method from the `Composite` to the
`Viewlet` component. This partially addresses
microsoft#4702 (comment)
    @mquandalle
    mquandalle committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    b6036c7 View commit details
    Browse the repository at this point in the history

  2. Calculate the sidebar optimal width correctly in case no folder is open

    @mquandalle
    mquandalle committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    bfe45ae View commit details
    Browse the repository at this point in the history